Improve tests for lexer#48
Open
neiser wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@a8m PS: If you like that test refactoring, I can also have a look at |
this enables running single tests from idea and also shows better reports when single tests fail
this was found after adding more test cases and finding that those lines were not covered
neiser
force-pushed
the
improve-tests
branch
from
20265a0 to
5f08da9
Compare
Contributor
Author
|
@a8m Sorry for bugging, but any comment on this? |
a8m
reviewed
Mar 21, 2023
…alue this reverts parts of previous commit and resolves a8m#48 (comment)
Contributor
Author
|
@a8m any update? I've addressed your comments, and maybe it's nice to merge it? |
Contributor
Author
|
@a8m Just checking in again after quite some time. Any desire to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed the tests to become subtests, which is quite convenient when debugging within GoLand or IntelliJ (which is the IDE I'm using). I guess also other IDEs should be able to detect the subtests now and allow to run them individually. Go tooling itself does support that!
While trying to improve test coverage (which is now 100%), I've found some dead code which I introduced in #42. My first PR was under the impression that the lexer supports nested things like
${foo:=${bar:=blub}}but I guess that's actually not supported (yet).@a8m Do you think supporting nested structures like this is worthwhile? That would require a large refactoring of the lexer I suppose.